XCOMMONS-3289: Allow overwritting xwiki.properties and xwiki.cfg properties via environment variable and Java system properties #4069
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmortagne
force-pushed
the
feature-systemconfiguration
branch
3 times, most recently
from
7b25a71 to
da26ac7
Compare
tmortagne
force-pushed
the
feature-systemconfiguration
branch
2 times, most recently
from
a66e5e3 to
00ab83c
Compare
…erties via environment variable and Java system properties
tmortagne
force-pushed
the
feature-systemconfiguration
branch
from
00ab83c to
2a85f32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
xwiki-commonsside of things can be reviewed on xwiki/xwiki-commons#1315Jira URL
https://jira.xwiki.org/browse/XCOMMONS-3289
Changes
Description
It's mainly about updating platform following xwiki/xwiki-commons#1315.
It also adds support for overwriting the following configuration sources with the
systemconfiguration source:xwikipropertiessuperadminuserguestuserpermanentxwikicfgExecuted Tests
TODO:
xwiki.propertieswould be a good "real" test.Expected merging strategy